feat: Expose some avatar root APIs #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaikoga
commented
Sep 30, 2023
Runtime/RuntimeUtil.cs
Outdated
| @@ -2,7 +2,11 @@ | |||
| using System.Collections.Generic; | |||
| using JetBrains.Annotations; | |||
| using UnityEngine; | |||
| using UnityEngine.SceneManagement; | |||
|
|
|||
| #if VRC_SDK_VRCSDK3 | |||
There was a problem hiding this comment.
Is it okay to add a version define like NDMF_VRCSDK3_AVATARS for "com.vrchat.avatars" to asmdef? (naming follows lilToon)
There was a problem hiding this comment.
Yes, that would be fine I think.
There was a problem hiding this comment.
In fact, I think it's necessary - I don't think the defines auto-set by the VRCSDK are a stable API.
|
Discussions: #39 |
bdunderscore
previously approved these changes
Oct 3, 2023
|
Looks like the CHANGELOG check has failed, please add an appropriate changelog entry and repush. |
bdunderscore
force-pushed
the
main
branch
10 times, most recently
from
83291e7
to
c059c66
Compare
bdunderscore
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #49
This PR exposes some utility APIs:
RuntimeUtil.IsAvatarRoot()RuntimeUtil.FindAvatarInParents()Also, avatar root determination is defined in a cross platform way:
VRCAvatarDescriptoras avatar root (unchanged).Animatoras avatar root (proposed). Less reliable if some users prefer setup with nesting avatar descriptors upon transplanting outfits (as mentioned in MA's EasySetupOutfit), but we don't want to use platform specific components here.