Deprecate duplicate AvatarRoot APIs #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdunderscore
reviewed
Nov 1, 2023
Editor/API/Util/MiscHelpers.cs
Outdated
Comment on lines
22
to
23
| [Obsolete("Please use RuntimeUtil.AvatarRootPath() instead.")] | ||
| public static string AvatarRootPath(this GameObject child) |
There was a problem hiding this comment.
RuntimeUtil isn't an extension method, I'd prefer to keep the convenience around...
kaikoga
force-pushed
the
obsolete_avatar_root_api
branch
from
e96b5b2
to
85a03ae
Compare
bdunderscore
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #69