Fix regression of diacritic placement of over-the-tie marks (#1092).

be5invis · May 29, 2021 · 3e615f4 · 3e615f4
1 parent 8f4c5e7
commit 3e615f4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 11 deletions.
diff --git a/changes/7.0.1.md b/changes/7.0.1.md
@@ -6,4 +6,5 @@
  * Fix missing variant of Latin Small Letter Ue (`U+1D6B`) (#1086).
  * Fix missing serif of Italic Latin Phi (#1087).
  * Remove `U+1FB93` ("Left Half Block and Right Half Inverse Medium Shade") since it is a reserved code point for now (#1088).
- * Add Black Rightwards Arrowhead (`U+27A4`) (#1090).
+ * Add Black Rightwards Arrowhead (`U+27A4`) (#1090).
+ * Fix regression of diacritic placement of over-the-tie marks (#1092).
diff --git a/font-src/glyphs/auto-build/composite.ptl b/font-src/glyphs/auto-build/composite.ptl
@@ -710,7 +710,6 @@ glyph-block AutoBuild-Enclosure : begin
 
 	do "triple-digit dashed-boxed"
 		createDashedBoxedGlyphs 3 : list
-			list 0x034F {'C.serifless' 'G.toothedSeriflessHooked' 'J.serifless'} WideWidth1
 			list 0xFFFC {'O'           'B.standardSerifless'      'J.serifless'} WideWidth1
 
 	do "inset boxed"

diff --git a/font-src/glyphs/space/index.ptl b/font-src/glyphs/space/index.ptl
@@ -41,6 +41,7 @@ glyph-block Symbol-Mosaic-NotDef : begin
 		set currentGlyph.autoRefPriority (-9999)
 
 	alias 'nonmarkingreturn' 0x000D 'zwsp'
+	alias 'cgj' 0x34F 'zwsp'
 	alias 'nbsp' 0xA0 'space'
 
 	alias 'enquad' 0x2000 'sp1'

diff --git a/font-src/otl/gsub-ccmp.ptl b/font-src/otl/gsub-ccmp.ptl
@@ -138,21 +138,16 @@ export : define [buildCCMP sink glyphStore markGlyphs] : begin
 			object [from {'revCommaAbove' 'perispomeniAbove'}] [to 'dasiaperispomeni']
 			object [from {'cyrlPsiliAbove' 'cyrlPokrytieAbove'}] [to 'cyrlPsiliPokrytieAbove']
 
-	define gnCgjNwid 'dashed-boxed3{847}{C}{G}{J}.NWID'
-	define gnCgjWwid 'dashed-boxed3{847}{C}{G}{J}.WWID'
-
 	define lookupCcmp-TieMarkLigature : add-lookup sink : object
 		.type 'gsub_ligature'
 		.substitutions : {}.concat
 			TieMarkFrom.map : lambda [gnFrom idx]
-				object [from {gnCgjNwid gnFrom}] [to TieMarkTo.(idx)]
-			TieMarkFrom.map : lambda [gnFrom idx]
-				object [from {gnCgjWwid gnFrom}] [to TieMarkTo.(idx)]
+				object [from {'cgj' gnFrom}] [to TieMarkTo.(idx)]
 
 	define lookupCcmp-TieMarkContextual : add-lookup sink : object
 		.type 'gsub_chaining'
 		.rules : list : object
-			match {[TieGlyphs.concat TieMarkTo] {gnCgjNwid gnCgjWwid} TieMarkFrom}
+			match {[TieGlyphs.concat TieMarkTo] {'cgj'} TieMarkFrom}
 			inputBegins 1
 			inputEnds 3
 			apply {{.at 1 .lookup lookupCcmp-TieMarkLigature}}

diff --git a/font-src/support/gr.js b/font-src/support/gr.js
@@ -77,12 +77,12 @@ const TieMark = {
 
 const TieGlyph = {
 	get(glyph) {
-		if (glyph && glyph.related) return glyph.related.TieMark;
+		if (glyph && glyph.related) return glyph.related.TieGlyph;
 		else return null;
 	},
 	set(glyph) {
 		if (!glyph.related) glyph.related = {};
-		glyph.related.TieMark = true;
+		glyph.related.TieGlyph = true;
 	}
 };