Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for diacritics and serifs #1115

Closed
VladWinner opened this issue Jun 10, 2021 · 7 comments
Closed

Fixes for diacritics and serifs #1115

VladWinner opened this issue Jun 10, 2021 · 7 comments
Labels
🐞 Bug

Comments

@VladWinner
Copy link

iosevka_report.pdf
iosevka_report.docx

  • Your font version: 7.0.4
  • Your font variant: Default / Slab / Aile / Etoile
@be5invis
Copy link
Owner

"diacritics go beyond the glyph borders" are all considered by design. We do not do special handling of compressing marks.

@be5invis
Copy link
Owner

U+1E65 in Unicode spec:
image

@be5invis
Copy link
Owner

For U+2010, 2011, 2012: U+2010 and 2011 should be identical with a hyphen (-) and U+2012 should follow the metrics of digits, therefore in Iosevka's metric system they ARE identical.

be5invis added a commit that referenced this issue Jun 10, 2021
@be5invis
* Add single-spacing TTC and Super TTC (#1112).
1e7bed4 
 * Fix geometry of:
   - Latin Small Letter B with Stroke (`U+0180`) (#1115).
   - Latin Letter Capital Gha (`U+01A2`), Latin Letter Small Gha (`U+01A3`) (#1115).
   - Latin Letter Inverted Glottal Stop with Stroke (`U+01BE`) (#1115).
   - Latin Capital Letter Hwair (`U+01F6`), Latin Small Letter Hwair (`U+0195`) (#1115).
   - Latin Capital Letter Y with Stroke (`U+024E`) (#1115).
   - Greek Capital Letter Theta (`U+0398`) (#1115).
   - Greek Capital Letter Xi (`U+039E`) (#1115).
   - Greek Capital Letter Delta (`U+0394`), Increment Symbol (`U+2206`) under Slab (#1115).
   - Greek Capital Letter Psi (`U+03A8`), Greek Small Letter Psi (`U+03C8`), Cyrillic Small Letter Psi (`U+0471`) (#1115).
   - Greek Small Letter Upsilon (`U+03C5`) (#1115).
   - Greek Small Letter Chi (`U+03C7`) (#1115).
   - Latin Small Letter A With Right Half Ring (`U+1E9A`) (#1115).
   - Latin Small Letter Y With Dot Below (`U+1EF5`) (#1115).
@be5invis
Copy link
Owner

be5invis commented Jun 10, 2021 •
edited

For upper case Greek with Tonos and other over marks, since Iosevka's default width is too narrow, implementing marks at left will significantly increase the complexity of the building process, so I picked what Pragmata Pro did (back in 2016 I think): place the marks above the letters.
It may be possible to shift the marks slightly to the left...

@VladWinner
Copy link
Author

Thank you again for your prompt response. I really appreciate the upcoming fixes!

About U+1E65
Also in Unicode spec:
image
Therefore, I think that this case is not so simple. But of course, the choice is yours. When I did the report, I was primarily guided by the glyph borders.
More fonts:
image
Arimo, Calibri, Carlito, Code2000, Consolas, Cousine, DejaVu Sans, DejaVu Serif, DMCA, Lato, Liberation Mono, Liberation Serif, Liberation Sans, Libertinus Serif, Linux Libertine, Recursive, Segoe UI, SF Pro Display, Spectral, STIX Two Math, STIX Two Text, Tinos, Pragmata Pro, Symbola

For U+2010/2011 and U+2012, the list of fonts is similar, including Pragmata Pro.
image
I think dash (U+2012) in Iosevka is already perfect, but hyphen should be shorter according to the rules of spelling marks design, but if that's not possible, then I really have nothing further to add.

be5invis added a commit that referenced this issue Jun 11, 2021
@be5invis
Fix placement of diacritics over uppercase Greek (#1115).
69de2a1
be5invis added a commit that referenced this issue Jun 11, 2021
@be5invis
Adjust metrics of Hyphens in Aile and Etoile (#1115).
25824fa
@be5invis
Copy link
Owner

The problem with the hyphen is that in ASCII it duplexes as the minus sign so it cannot be too short. However for Aile ane Etoile, changing metrics is sort of acceptable.

be5invis added a commit that referenced this issue Jun 11, 2021
@be5invis
Further adjust metrics of punctuations in Aile and Etoile (#1115).
de7156e
be5invis added a commit that referenced this issue Jun 11, 2021
@be5invis
Fix geometry of Latin Capital Letter I with Ogonek (U+012E), Latin …
34cae3f 
…Small Letter with Ogonek (`U+012F`) (#1115).
@be5invis
Copy link
Owner

All issues, except for "overflowing stacking marks" are fixed. Stacking marks are considered by design. Resolve as Fixed.

@dscorbett dscorbett mentioned this issue Jun 19, 2021
Closed
@VladWinner VladWinner mentioned this issue Jul 29, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@be5invis @VladWinner