Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new ligation set for the Dafny programming language? #1271

Closed
cpitclaudel opened this issue Jan 3, 2022 · 6 comments
Closed

Add a new ligation set for the Dafny programming language? #1271

cpitclaudel opened this issue Jan 3, 2022 · 6 comments

Comments

@cpitclaudel
Copy link

cpitclaudel commented Jan 3, 2022

Hello, and thanks for the work on Iosevka!

Would it be easy to add a new ligation set for the Dafny programming language (https://github.com/dafny-lang/dafny/)?

Here are the ligations which I think are relevant:

image

There are two more symbols that (I think) Iosevka does not have (!! which should have the exclamation points slightly closer to each other and :| which should center the bar like := does), as well as one exception: :: is rendered as a thick center dot in Dafny:

image

Happy to submit a patch if that's easier and if a new ligation set would be acceptable.

Thanks!

@be5invis
Copy link
Owner

be5invis commented Jan 4, 2022

:: is rendered as a thick center dot in Dafny

Wait what?

@cpitclaudel
Copy link
Author

Wait what?

That's just the convention when rendering Dafny code, both in academic papers and in the Emacs mode for it. It's not completely unconventional, either: https://tex.stackexchange.com/questions/201539/how-to-produce-dot-between-quantifiers

@VladimirMarkelov
Copy link

Correct me if I am wrong, but I think that if a font provides a ligature, it works the same way for everyone. In this case, making "::" a think dot may make a lot of developers in other languages very surprised. E.g, ubiquitous C++ extensively uses "::" for namespace delimiter.

@be5invis
Copy link
Owner

be5invis commented Jan 5, 2022

I'd like to NOT add a ligature turning :: into ·, instead, I'd like to simply kern them together.

@be5invis
Copy link
Owner

be5invis commented Jan 5, 2022

Using fonts to do such a merge is a very, very bad idea. Actually, I do not want to do such things for the second time.
(The first time is for inequalities).

@cpitclaudel
Copy link
Author

Correct me if I am wrong, but I think that if a font provides a ligature, it works the same way for everyone.

I don't think that's right: for example Iosevka already has two different renderings for <> and for ===.

I'd like to NOT add a ligature turning :: into ·, instead, I'd like to simply kern them together.

Works for me. Thanks a lot!

be5invis added a commit that referenced this issue Jan 6, 2022
@be5invis be5invis closed this as completed Jan 6, 2022
xinhaoyuan pushed a commit to xinhaoyuan/Iosevka that referenced this issue May 22, 2022
xinhaoyuan pushed a commit to xinhaoyuan/Iosevka that referenced this issue May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants