Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powerline glyphs #4

Closed
Gonzih opened this issue Jul 28, 2015 · 8 comments
Closed

Powerline glyphs #4

Gonzih opened this issue Jul 28, 2015 · 8 comments
Milestone

Comments

@Gonzih
Copy link

Gonzih commented Jul 28, 2015

Hi, I love this font! :) great job!

But what I am miss right now in it is powerline glyphs. I tried to manually use powerline font patcher and got at least some result :

area-screenshot

Unfortunately there is a small gap on each side of the glyph. And instead of monkey patching/manually adjusting glyphs I though that it might be possible to contribute to the original font. But I'm honestly not sure where to start. Powerline font patcher stores glyphs in a sfd format and I'm not sure what to do with them.

Can you give me some tips on where to look and at least how to approach this problem?

Thanks a lot!

@Gonzih
Copy link
Author

Gonzih commented Jul 28, 2015

I read on this problem with powerline patchers and looks like iosevka is actually easy to patch. Most of other fonts get messed up much worse after patching.

@be5invis be5invis added this to the 0.1.0 milestone Jul 28, 2015
@be5invis
Copy link
Owner

So, how does this looks like?
powerline

@Gonzih
Copy link
Author

Gonzih commented Jul 30, 2015

area-screenshot

It looks great! I think issue with spacing between characters is problem with my linux, not with the font. Playing with dpi setting and line-spacing solved it before for the different fonts.

Thanks a lot! This is great!

@trusktr
Copy link

trusktr commented Sep 11, 2015

@be5invis I'm seeing this on the website, in Chromium Linux 45.0.2454.85 (64-bit):

screenshot from 2015-09-11 13-28-44

Note the edges of the triangles going past the edge of the powerline.

@Gonzih
Copy link
Author

Gonzih commented Sep 11, 2015

I don't see that in terminal.
On Sep 11, 2015 10:32 PM, "Joseph Orbegoso Pea" notifications@github.com
wrote:

I'm seeing this on the website, in Chromium Linux 45.0.2454.85 (64-bit):

[image: screenshot from 2015-09-11 13-28-44]
https://cloud.githubusercontent.com/assets/297678/9825644/8ae5b39a-5889-11e5-8831-8f73f2ed2f6d.png

Note the edges of the triangles going past the edge of the powerline.


Reply to this email directly or view it on GitHub
#4 (comment).

@be5invis
Copy link
Owner

@trusktr It's caused by Chrome's rounding error. They work well on terminal.

@frol
Copy link

frol commented Jun 16, 2016

I'm using aur/ttf-iosevka-term 1.9.0-2 (Arch Linux AUR packaging) and here is what I get in Gnome 3 Terminal (Gnome 3.20.2, VTE 0.44.2):

screenshot from 2016-06-16 18-26-17

(It is not a regression, it looks like that ever since I have installed it.)

Is this a known issue or how can I fix this?

P.S. Thank you for Iosevka gorgeous font!

@be5invis
Copy link
Owner

be5invis commented Jun 16, 2016

@frol You can follow the path with @robertgzr that you can actually adjust the position and size of Powerline glyphs if you really want to fit them perfectly (see #86). If you do not want to rebuild Iosevka, you can also try to adjust the line height or tweak Freetype’s rendering options.
Powerline glyphs are extremely hard to “being perfect”. Correctly rendering them depends on the OS and even rounding rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants