Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken ligatures on Linux #490

Closed
alexeyten opened this issue Apr 11, 2020 · 11 comments
Closed

Broken ligatures on Linux #490

alexeyten opened this issue Apr 11, 2020 · 11 comments
Labels
External

Comments

@alexeyten
Copy link
Contributor

  • Your font version: commit 52d0cc4
  • Your font variant: Iosevka Term
  • Your operating system (name and version): Elementary OS 5 (based on Ubuntu 18.04)
  • Your application using Iosevka: Any, including Firefox, Chromium, VS Code, etc.

Builded with:

  • Your Node.js version: v12.16.1

  • Your otfcc version: 0.9.5.

  • Your private-build-plans.toml, if present: Just renamed Iosevka Term with only regular and bold weights

[buildPlans.iosevka-dev]
family = "Iosevka Dev"
design = ["sp-term"]


[buildPlans.iosevka-dev.weights.regular]
shape = 400  # Weight for glyph shapes.
menu  = 400  # Weight for the font's names.
css   = 400  # Weight for webfont CSS.

[buildPlans.iosevka-dev.weights.bold]
shape = 700
menu  = 700
css   = 700

[buildPlans.iosevka-dev.slants]
upright = "normal"
italic = "italic"

[buildPlans.iosevka-dev.widths.normal]
shape = 5          # Width of glyph shapes.
menu  = 5          # Width for the font's names.
css   = "normal"   # "font-stretch' property of webfont CSS.

Ligatures went wrong after in commit 0bb02b9

Test page: https://result.dabblet.com/gist/50617a712ba980fc373395fac5bca7a5

52d0cc4
image

3.0.0-rc.6
image

Freetype version 2.8.1-2ubuntu2
Pango version 1.40.14-1ubuntu0.1
@be5invis
Copy link
Owner

image
It looks very normal here on Chromium, which uses latest Harfbuzz.
Note that Pango 1.40 comes from 4 years ago, which is considered outdated.

@be5invis
Copy link
Owner

iosevka-term.zip
Can you try this which is built on my computer. I'd like to exclude the influence of otfcc which has a newer alpha (0.10.x, but then I discontinued it).

@be5invis
Copy link
Owner

be5invis commented Apr 11, 2020 •
edited
Loading

Another cause may be font caching — caching may lead to incorrect shaping results especially the newer commit massively changed how non-encoded glyphs arranged.
To refresh that, run

sudo fc-cache -f -v

be5invis added a commit that referenced this issue Apr 11, 2020
@be5invis
Docs: fix required otfcc version (#490)
4588eb6
@be5invis
Copy link
Owner

I can confirm that it should be an issue of otfcc 0.9.5, but it is fixed by otfcc 0.10.3-alpha. cc. @CyanoHao

@IceMan81
Copy link
Contributor

IceMan81 commented Apr 12, 2020 •
edited
Loading

@be5invis Could you release the otfcc alpha version via brew as well? Would make it easier to update and build latest on a mac.

@be5invis
Copy link
Owner

@IceMan81 I do not have macintosh machines. That is the problem.
@Liam0205 did that for me.

@be5invis
Copy link
Owner

Also I do have plan to remove it from the dependencies in the future but it may take a lot of time.

@IceMan81
Copy link
Contributor

@be5invis Understood!
@Liam0205 Would you be able to push out the alpha versions to homebrew?

@Liam0205
Copy link

Liam0205 commented Apr 12, 2020 •
edited
Loading

@IceMan81 Moving house, I could do this later these days.

@alexeyten
Copy link
Contributor Author

alexeyten commented Apr 12, 2020 •
edited
Loading

Can you try this which is built on my computer.

This works well.
Will update otfcc.
Thank you for a great font, btw. 😃

black-black-cat added a commit to black-black-cat/Iosevka that referenced this issue Apr 18, 2020
@black-black-cat @be5invis
pull upstream (#3)
93ebb43 
* More arrow fixup

* Add more detailed docs for building. Fixes be5invis#474

* Add docs for width customization

* Update Node.JS version requirement. Fixes be5invis#486

* Fix phonetic ligatures' shape. Now they are connected more closely (be5invis#488).

* Remove unused logs

* Fix LATIN SMALL LETTER TC DIGRAPH WITH CURL overflow

* Fix shape of U+AB30, U+AB64 and U+1DE7 (be5invis#489).

* Docs: fix required otfcc version (be5invis#490)

* Make dot removal work if a below or other mark is between the base and above mark

* Fix export of U+478 and U+479

* Make "ligtions using dlig and calt at same time" less strange

* Fixup format

* Fix shape of U+029A, U+1D08, U+1D4C (be5invis#491).

* remove "ai" knots

* Add U+AB66 and U+AB67 (be5invis#488).

* Force f-eng to be connected

* Add [reverse-rule] to simplify reverse subst code

* Make GSUB more efficient

* Need to keep correspondence

* Fix shape of U+1DF0 (be5invis#497).

* Adjust length of diagonal arrows

* Make double arrow only work with arrow2 selector

* Add ligation for shift-equal operators (>>=, <<=, >>>=, <<<=)

* Update visualization data

* Add ligation group "CLIK"

* Add warning about auto-generated README sections

* Add overrideSupportedLanguages list

* Bump version

* Fix incorrect sample images of ligations

Co-authored-by: Belleve Invis <belleve@typeof.net>
@IceMan81
Copy link
Contributor

@IceMan81 Moving house, I could do this later these days.

@Liam0205 @be5invis
I've an open PR for the updated tap definition. Could one of you take a look and accept?
caryll/homebrew-tap#4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
External
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@alexeyten @be5invis @IceMan81 @Liam0205