Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v-u-without-bar and italic cyri/cyrtse(/cyrdzhe) #625

Closed
pv4 opened this issue Jul 2, 2020 · 6 comments
Closed

v-u-without-bar and italic cyri/cyrtse(/cyrdzhe) #625

pv4 opened this issue Jul 2, 2020 · 6 comments

Comments

@pv4
Copy link

pv4 commented Jul 2, 2020

When using v-u-without-bar the generated u glyph is used for italic variant of cyri, cyrtse and cyrdzhe. As a result the mentioned cyrillic glyphs look incorrect for me as for native Russian speaking man.

On the picture attached the red regions are what looks wrong. The green region is what is done right (to simplify comparison for you).

The attached patch fixes the issue for me. cyri.italic and cyrtse.italic must refer to u.withBar instead of just u.

The cyrdzhe.italic glyph is also fixed in the patch. I've never seen this one in my life but according to https://en.wikipedia.org/wiki/List_of_Unicode_characters#Cyrillic it is symmetric and therefore should refer to u.withoutBar.

I only noticed these three glyphs but there may be other ones as well that become incorrect when using different variants for latin glyphs they refer to.

comparison
Iosevka-3.2.2-cyrillic_italic.patch.gz


  • Your font version: 3.2.2
@pv4 pv4 added the 🐞 Bug label Jul 2, 2020
@be5invis
Copy link
Owner

be5invis commented Jul 3, 2020

image

@pv4
Copy link
Author

pv4 commented Jul 3, 2020

Just for the record. You're right. The cyrdzhe.italic can be unsymmetric. The attached image is from wikipedia.

Serbian-italic

@eevan78
Copy link

eevan78 commented Aug 12, 2020

I'm а native Serbian.
In italic variants off all typefaces, the lowercase letter dzhe (џ) has the vertical line in the middle of the character width.
The one in the proposed glyph here should be moved a bit to the right, so that it sits in the center, like it is on the uppercase Џ.

@be5invis
Copy link
Owner

@eevan78 Italic џ is handled in different ways in sans-serif fonts: some of them use off-center bars and some of them use detached bar. Perhaps we could try the detached variant.

Noto Sans
image

@be5invis
Copy link
Owner

image
This should look better

@eevan78
Copy link

eevan78 commented Aug 12, 2020

Yes, I agree, this one looks better. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants