Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertical bar in italic to be upright? #652

Closed
12425 opened this issue Jul 29, 2020 · 6 comments
Closed

Vertical bar in italic to be upright? #652

12425 opened this issue Jul 29, 2020 · 6 comments

Comments

@12425
Copy link

12425 commented Jul 29, 2020

Vertical bar character | in italic or oblique is also oblique, which makes the table borders ugly.
In DejaVu Sans Mono it is upright, can you also make it upright, or add an option?
Thanks.

| H1  | H2  | H3  |
| --- | --- | --- |
|     |     |     |
|     |     |     |
@12425 12425 added the 🐞 Bug label Jul 29, 2020
@be5invis
Copy link
Owner

Slope of symbols is more like a design choice. JetBrains Mono and Victor Mono use slanted | while Source Code Pro uses upright (it also force math operators, arrows, most geometric symbols and pictograms to be upright). I currently only force box-drawing characters to be upright in italics, perhaps we could have an CV for |.

@be5invis be5invis added this to the 3.4 milestone Jul 29, 2020
@12425
Copy link
Author

12425 commented Jul 30, 2020

Thank you! Looking forward to it.

@be5invis
Copy link
Owner

image

@12425
Copy link
Author

12425 commented Aug 26, 2020

Sorry, but I'm afraid the commit only changed sans, but the slab vertical bar is still oblique.
By the way, can we add variant for upright [ and ]?

@be5invis
Copy link
Owner

@12425 In the specimen you could see VXCZ variants for them under Slab -- note that this variant is only visible under Italics.
image
For custom building, you need to include v-bar-force-upright style selector after slab. I tried a custom build and it worked.

@12425
Copy link
Author

12425 commented Aug 26, 2020

My bad, I previewed it in NexusFont, which shows oblique bar. After installing to the system, it shows upright. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants