Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ligatures for {| and |} #767

Closed
2 of 6 tasks
asazernik opened this issue Dec 4, 2020 · 5 comments
Closed
2 of 6 tasks

Ligatures for {| and |} #767

asazernik opened this issue Dec 4, 2020 · 5 comments

Comments

@asazernik
Copy link

  • The requested character is...
    • Latin
    • Cyrillic
    • Greek
    • Punctuation
    • Symbol
  • Some other monospace/programming fonts supported this character. Provide images below.

This pair is common in Javascript with Flow type annotations, where this is used in type annotations to denote an exact object type. ({ a: number } specifies a type that can have properties other than a, while {| a: number |} specifies a type that has only the property a.)

The Fira versions of these ligatures are below.

image

@be5invis
Copy link
Owner

be5invis commented Dec 5, 2020

I have to say one thing... Fira's version is horrible. We need more crafted design.

@be5invis be5invis added this to the 4.1 milestone Dec 5, 2020
@asazernik
Copy link
Author

Fair enough. I prefer Fira's ligature to the two adjacent characters, but that's a low low bar.

@be5invis
Copy link
Owner

be5invis commented Dec 5, 2020

Plan to make something like this. Also adding [| and |] for Haskell-ish idiom bracket.
image

@be5invis
Copy link
Owner

be5invis commented Dec 6, 2020

@asazernik They are now in dlig.

@be5invis
Copy link
Owner

be5invis commented Dec 6, 2020

Closing. I am targeting a version 4.0.2 release tomorrow with these included, as well as fixes of symbols.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants