Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With p=earless-* , cyrl/er looks unnatural #769

Closed
pv4 opened this issue Dec 9, 2020 · 0 comments
Closed

With p=earless-* , cyrl/er looks unnatural #769

pv4 opened this issue Dec 9, 2020 · 0 comments

Comments

@pv4
Copy link

pv4 commented Dec 9, 2020

Using p=earless-* causes cyrl/er to look unnatural, at least for me as for a native russian speaking person.

p=earless-* at first looks unnatural too but it seems more natural than cyrl/er=earless-*. That's probably because most of cyrillic letters are more cornered (at top and bottom) (вгджийклмнптухцчшщъыьюя) while most of latin letters are more rounded (abcdefghjmnopqrstu).

Moreover using n=earless-* and m=earless-* causes the dependent cyrl/pe.italic and cyrl/te.italic to have the top left ear while using p=earless-* causes cyrl/er.italic to NOT have the one, that may be considered as an inconsistency (but the main issue does not relate to the italic style only; it relates to the upright style as well). earless

The patch below fixes the issue for me by using cyrl/er=eared when p=earless-* is in use.

BUT PLEASE KEEP IN MIND THE FOLLOWING!

"Unnatural" look may be subjective to me. If there is a possibility to ask other russian native speaking people for their opinion relating to the issue, it would be better to do that before changing anything. As for me, I got used to p=earless-* look shortly and I was unable to get used to the related cyrl/er=earless-*.

diff -Napur Iosevka.orig/font-src/glyphs/letter/latin.ptl Iosevka/font-src/glyphs/letter/latin.ptl
--- Iosevka.orig/font-src/glyphs/letter/latin.ptl       2020-12-06 22:17:14.000000000 +0300
+++ Iosevka/font-src/glyphs/letter/latin.ptl    2020-12-08 05:53:37.509061983 +0300
@@ -3159,7 +3159,7 @@ glyph-block Letter-Latin-Lower-P : begin
                        include : SmallPSerifLB
 
        select-variant 'p' 'p'
-       alias 'cyrl.er' 0x440 'p'
+       select-variant 'cyrl/er' 0x440 (shapeFrom -- 'p')
 
        glyph-block-import Letter-Blackboard : BBS BBD BBBarLeft
        create-glyph 'mathbb/p' 0x1D561 : glyph-proc
diff -Napur Iosevka.orig/params/variants.toml Iosevka/params/variants.toml
--- Iosevka.orig/params/variants.toml   2020-12-06 22:17:14.000000000 +0300
+++ Iosevka/params/variants.toml        2020-12-08 05:47:27.517049027 +0300
@@ -813,21 +813,25 @@ tag = 'cv24'
 rank = 1
 description = '`p` with top-left ear'
 selector.p = 'eared'
+selector."cyrl/er" = "eared"
 
 [prime.p.variants.earless-corner]
 rank = 2
 description = '`p` without top-left ear (corner)'
 selector.p = 'earlessCorner'
+selector."cyrl/er" = "eared"
 
 [prime.p.variants.earless-rounded]
 rank = 3
 description = '`p` without top-left ear (rounded)'
 selector.p = 'earlessRounded'
+selector."cyrl/er" = "eared"
 
 [prime.p.variants.motion-serifed]
 rank = 4
 description = '`p` with motion serifs'
 selector.p = 'motionSerifed'
+selector."cyrl/er" = "motionSerifed"
 
 
 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants