-
Notifications
You must be signed in to change notification settings - Fork 560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cf8c550 and cyrl/be shape change #901
Comments
Yes, I saw them. But their ring doesn't differ from x-height as much as the previous Iosevka variant did. And the most of fonts still have x-height ring. Anyway, the current variant is fine. It's much better. Thanks! |
@pv4 Just because x-height "б"-ring (or rather an oval) is implement in a certain number of fonts doesn't mean that this fonts represent Cyrillic letter "б" fully correctly. Don't take it as an insult. We need to go deeper.
That is, if we proceed from correct logic of height in Cyrillic ("б"-oval ≈ x-height < "o"), then you are certainly right, but given amount of Iosevka font styles, this is a forced measure. @be5invis An ideal compromise would be the equation of "б"-oval with x-height, but in non-bold styles only (maybe from light to regular). This method is used in PT Mono and IBM Plex Mono which contain a high-quality realization of the Cyrillic alphabet's peculiarity. But I am not really sure that it is possible to implement this within current Iosevka files generation logic. |
@VladWinner thanks for the link, I'll definitely watch it when I have time. But WRT PT fonts I would not trust their creators 100%. I used PT Mono for some time but had switched to another font because in PT Mono different letters looked inconsistent in term of serifs. Latin uppercase |
@pv4 |
The commit cf8c550 "Shape refinement of grek/delta and cyrl/be" decreased the height of the circle of
cyrl/be
. Before that it was ofx-height
height. Now it's less than that and this's the only cyrillic (russian) letter that doesn't align with x-height, that being looking strange/inconsistent.It would not be an issue if there were some other letters being "not x-height" (or for fancy fonts among which the most known are
microsoft comic sans
andsamsung choko cooky
) as could be found on some sites with fonts to buy/download. But for Iosevka it doesn't seem to be the case since Iosevka style looks more solid, serious.Besides, on some small font sizes
cyrl/be
now looks very likesix=open-contour
.Is there a reason why the shape was changed? For russian cyrillic alphabet the current
cyrl/be
looks a little bit like a stranger. Did the new shape fixes some other cyrillic alphabet (Belorussian, Ukrainian, etc)?Is it possible to get the old shape somehow? Revert the commit, introduce a parameter (similar to
onumZeroHeightRatio
)? However I think introducing a variant for yet another non-latin letter would be an overhead.Isn't there a similar issue for
grek/delta
?The text was updated successfully, but these errors were encountered: