Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complement Search, Amend Features #18

Merged
merged 2 commits into from
May 23, 2021
Merged

Complement Search, Amend Features #18

merged 2 commits into from
May 23, 2021

Conversation

ChanuYu
Copy link
Collaborator

@ChanuYu ChanuYu commented May 23, 2021

search 버튼 클릭 시 조회된 데이터가 뜨게 하였고 옆에 닫기 버튼을 추가하였습니다.
기존데이터 수정 부분에서 매수/매도량에 0을 입력하면 저장된 데이터를 삭제하는 기능을 추가하였습니다.

추가로 논의해야 할 기능

function getCurrentPrice(obj) {}

//위의 getCurrentPrice 함수를 구현하여 return 값을 user 객체의 current_price 속성에 넣어줘야 합니다.
//아래의 함수는 current_price가 쓰이는 부분입니다.
function addSpanChild(div, idx) {
    let target = user_list[idx];
    let child = document.createElement("span");
    child.className = "me-4";
    child.textContent = `${target["user_name"]}님의 주식 ${target["stock_name"]}의 정보: 현재 가격은 ${target["current_price"]}, 수익금은 ${target["margin"]}입니다.`;
    div.appendChild(child);
}

function getCurrentPrice(obj) {} 함수는 #17 을 해결하고 진행해야 할 거 같습니다.

Copy link
Collaborator

@wshf253 wshf253 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다

@wshf253
Copy link
Collaborator

wshf253 commented May 23, 2021

이거 다 수정하실 거 없으시면 지금 merge해도 되나요?

@ChanuYu
Copy link
Collaborator Author

ChanuYu commented May 23, 2021

네 code review 하셨으면 Merge pull requset 눌러주시면 됩니다

@wshf253 wshf253 merged commit 643f2d2 into master May 23, 2021
@ChanuYu ChanuYu mentioned this pull request May 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants