Skip to content
This repository has been archived by the owner on Dec 27, 2022. It is now read-only.

Add audio controls for individual tabs #711

Closed
1 of 3 tasks
taravancil opened this issue Oct 18, 2017 · 1 comment
Closed
1 of 3 tasks

Add audio controls for individual tabs #711

taravancil opened this issue Oct 18, 2017 · 1 comment
Labels
electron enhancement Change that's on the roadmap

Comments

@taravancil
Copy link
Contributor

taravancil commented Oct 18, 2017

It would be great to be able to indicate which tabs are playing audio, and to be able to mute the audio from the tab:

screen shot 2017-10-18 at 10 27 45 am

Here are the isolated tasks we'll need to complete in order to make this happen:

  • Detect when audio is being played, and identify which tab is playing it
  • Implement muting/unmuting audio in a given tab
  • Wire up the tab UI

If anyone is interested in helping, Brave's codebase might be helpful. They implemented this feature and they also use Electron.

@taravancil taravancil added enhancement Change that's on the roadmap PRs welcome! labels Oct 18, 2017
pfrazee added a commit that referenced this issue Nov 9, 2017
@pfrazee
Copy link
Member

pfrazee commented Nov 9, 2017

We need to update electron to support telling us when audio is playing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron enhancement Change that's on the roadmap
Projects
None yet
Development

No branches or pull requests

2 participants