This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Make website template use relative asset URIs #1311
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the templates for new Dat sites to use relative paths.
I think it's important to encourage people composing sites in Beaker to use relative paths for assets at all times. Specifically with things like
homebase
, I can make an https mirroring service that mirrors these sites from any subdirectory of a pinning host. This would break a site with absolute paths but a site with relative paths would still work. Obviously we can't enforce this coding style but encouraging it by providing this style in the template is a start.(The js file listed in the website template already uses a relative path so I didn't have to change it.)