This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Label dat as 'Secure P2P' in the navbar (close #279) #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Strange. .. I did click the label with latest master build. ... Nothing happens :/ |
|
That is strange. If you open the Beaker dev tools (under BeakerDev) do you see an error in the console? |
|
nope. Did already check the DOM. the div and all the elements are there. .. They are just invisible. Seems to be related to #285 |
What electron version are you on? I haven't merged that PR yet so you should be on 1.5.0 |
I'll post here. |
pmario
referenced
this pull request
Feb 8, 2017
|
found it: 72d8c12#commitcomment-20801743 |
|
Thanks. I'll get a fix done this afternoon.
…On Wed, Feb 8, 2017 at 10:51 AM, Mario Pietsch ***@***.***> wrote:
found it: 72d8c12#commitcomment-20801743
<72d8c12#commitcomment-20801743>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#283 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABNhU4F5MWTYnzz4AxE1vXaB9nAmG_lnks5rafJ0gaJpZM4L5B_f>
.
|
This was referenced Jul 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per @pmario's suggestion in #278, and per the decisions in #279, this PR updates the navbar UI as follows:
The "Learn more" link goes to https://github.com/beakerbrowser/beaker/wiki/Is-Dat-%22Secure-P2P%3F%22