Update events logic to allow mapping specific events to specific tags #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-lombardi
requested changes
Jun 27, 2024
pkg/types/event.go
Outdated
|
|
||
| var EventAbstractionTriggerSchemaVersion = "1.0" | ||
|
|
||
| type EventAbstractionTriggeredSchema struct { |
There was a problem hiding this comment.
Shouldn't this have an event_type field or something? this feels ambiguous
There was a problem hiding this comment.
The stubtype includes the abstraction and trigger type
pkg/repository/base.go
Outdated
| @@ -147,6 +147,7 @@ type EventRepository interface { | |||
| PushContainerStoppedEvent(containerID string, workerID string) | |||
| PushWorkerStartedEvent(workerID string) | |||
| PushWorkerStoppedEvent(workerID string) | |||
| PushAbstractionTriggeredEvent(workspaceId string, stub *types.Stub) | |||
There was a problem hiding this comment.
I don't really like this name, it feels confusing. I'd almost argue for more specific functions even at the risk of more code / being more verbose. I./e. PushDeployedStubEvent() PushServedStubEvent()
There was a problem hiding this comment.
I like this better. I renamed the subject from abstraction -> stub
luke-lombardi
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTP Inputs in Fluent-bit dynamically set
tagsbased off the URI of the request.e.g. a request to
fluentbit.monitoring:9880/tag_nameresults in fluent-bit automatically setting a tag oftag_nameto the eventThese tag names are then matched with an output in the example below
By default, the events will map to the tag
http.1unless it's override in the input. However, I added a mapping that can be set inconfig.yamlto map events to specific tags by event name as such: