-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArgumentError when decoding an int > 134_217_727 #29
Comments
Disregard Question 3: I commented out the Then, I changed
|
Ok, so after a bunch more research, it seems that the threshold is
|
After more research, and studying the avro-official decoding/encoding implementations in ruby and javascript, and it seems like the implemented logic in this library is pretty similar, except swapping while loops for recursive calls. A key difference is that the ruby implementation is that the integer-related logic delegates to the same logic for type Also, the inability to decode integers that have an absolute value larger than
|
Change the implementation of variable `integer` and `long` decoding based on the `klarna/erlavro` erlang implementation. This fixes the issue of not decoding correctly integers above 134_217_727. Fixes beam-community#29
NICE! |
Hello! I'm getting an exception from the library when trying to decode nine digit integers greater than or equal to
140_000_000
. I've pasted the exception and its trace below:Here's the pertinent snippet of the
.avsc
schema file in question:I've verified that 130_000_000 can be successfully decoded, but
140_000_000
cannot be successfully decoded.There are a few things I'm not quite getting, and they're probably a result of my admitted lack of deep elixir debugging experience:
AvroEx.decode
into a function that matches against either{:ok, decoded_message}
and a default clause, but these exceptions are not being handled by the default function clause. Do you know why that might be?I'd love to help solve this issue in any way I can, so please let me know how I can be a helpful collaborator and contributor. Thank you so much in advance!
The text was updated successfully, but these errors were encountered: