Empty recipients #40
Closed
Empty recipients #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 23, 2016 00:00
I'm not sure about this but I'm going to give it a try.
| if email.to == [] and email.cc == [] and email.bcc == [] do | ||
| {:no_recipients, email} | ||
| else | ||
| send_email(email, config) |
There was a problem hiding this comment.
Maybe this should be {:ok, email} so you can pattern match on the result...? Then I'd need to add deliver! and deliver_async! I think, and not raise here if there is an API error, instead return {:error, mandrill_response}
There was a problem hiding this comment.
Being able to pattern match on the result seems useful. As you said you would need to add deliver! and deliver_async! but that's probably fine.
|
Closed in favor of #67 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure about this, but I'm going to open it up and think about it a bit