Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in LocalAdapter with an open_email_in_browser_url config #590

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

minhajuddin
Copy link
Contributor

When LocalAdapter is used with an open_email_in_browser_url config, delivering emails throws an error https://github.com/thoughtbot/bamboo/blob/master/lib/bamboo/adapters/local_adapter.ex#L34-L37 returns a {"", 0} which doesn't match https://github.com/thoughtbot/bamboo/blob/master/lib/bamboo/mailer.ex#L206-L209

@germsvel
Copy link
Collaborator

Thanks for opening this PR @minhajuddin.

I think this is solving the same thing #589 solved, but I really like the idea of returning the email as the second element in the {:ok, any} response, and also adding the test.

If you feel up for rebasing and introducing those differences, I'd love to get that in. Otherwise, if you feel like #589 solved it well enough, then we can close this PR.

@minhajuddin
Copy link
Contributor Author

Thanks, @germsvel rebased my PR.

@germsvel
Copy link
Collaborator

Thanks! That was fast ⚡

@germsvel germsvel merged commit 69d48e8 into beam-community:master Mar 10, 2021
@germsvel
Copy link
Collaborator

Thanks for this work!

@SamuelWillis
Copy link
Contributor

Nice, thanks for this improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants