Set default timeout in test helpers to 100ms #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit aa8c458 introduced the ability to accept a timeout option in test helpers. To consolidate logic, it extracted a `get_timeout/1` function, but it incorrectly set the default value to 1000 ms. This commit corrects that by setting it to 100 ms. We also take the opportunity to use the `get_timeout/1` helper from the `refute_timeout/1` function, thus we consolidate all fetching of the `:timeout` option to the `get_timeout/1` helper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit aa8c458 introduced the ability to accept a timeout option in test helpers. To consolidate logic, it extracted a
get_timeout/1function, but it incorrectly set the default value to 1000 ms. This commit corrects that by setting it to 100 ms.We also take the opportunity to use the
get_timeout/1helper from therefute_timeout/1function, thus we consolidate all fetching of the:timeoutoption to theget_timeout/1helper.