Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise helpful error when using ExMachina.create functions #106

Closed
paulcsmith opened this issue Mar 18, 2016 · 3 comments
Closed

Raise helpful error when using ExMachina.create functions #106

paulcsmith opened this issue Mar 18, 2016 · 3 comments
Milestone

Comments

@paulcsmith
Copy link
Contributor

I think it would be good to add helpful errors when calling create, create_pair and create_list on ExMachina so people know that things have changed when they upgrade to 1.0.0

@paulcsmith paulcsmith added this to the Release 1.0 milestone Mar 18, 2016
@paulcsmith
Copy link
Contributor Author

@davidkuhta is working on this one I believe :)

@davidkuhta
Copy link
Contributor

davidkuhta commented May 5, 2016

@paulcsmith
Note: this is the error-helpers branch.

create functions with error-helpers

Tests split based on arity to match existing tests:
create/2, create_pair/2, create_list/3 tests
create/1 test

@paulcsmith
Copy link
Contributor Author

@davidkuhta This is great. Thanks for working on them. Could you open a pull request for these two issues? That would make it easier to see what changes and give comments :D

davidkuhta added a commit to davidkuhta/ex_machina that referenced this issue May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants