Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Credo fixes to comply with --strict option #177

Merged
merged 2 commits into from Feb 10, 2019
Merged

Credo fixes to comply with --strict option #177

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b22917e
Credo fixes to comply with --strict option
kbaird Feb 8, 2019
ae8fc56
Add --strict option to mix credo on Travis
kbaird Feb 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/jsonapi.ex
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ defmodule JSONAPI do
in your `config/config.exs`:
config :jsonapi, :json_library, Jason
"""
def json_library() do
def json_library do
module = Application.get_env(:jsonapi, :json_library, Jason)

if Code.ensure_loaded?(module) do
Expand All @@ -30,7 +30,5 @@ defmodule JSONAPI do
@doc """
This returns the MIME type for JSONAPIs
"""
def mime_type() do
@mime_type
end
def mime_type, do: @mime_type
end
4 changes: 2 additions & 2 deletions lib/jsonapi/serializer.ex
View file
Open in desktop
Expand Up @@ -5,8 +5,8 @@ defmodule JSONAPI.Serializer do

import JSONAPI.Ecto, only: [assoc_loaded?: 1]

alias JSONAPI.Utils.String, as: JString
alias JSONAPI.Config
alias JSONAPI.{Config, Utils}
alias Utils.String, as: JString

require Logger

Expand Down