Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relationships spec & external relationship use-case #295

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Fix relationships spec & external relationship use-case #295

merged 3 commits into from
Jun 26, 2023

Conversation

mattpolzin
Copy link
Member

The features of #270 were broken in two ways that this PR fixes.

  1. The @spec for the relationships callback for JSONAPI.View actually did not allow for the various new structures a relationships callback is allowed to return under the above PR.
  2. The PR was intended to support (among other more general purposes) remapping of an attribute field to a relationship -- this is niche, but sometimes quite useful. The above PR and its tests failed to fully realize that goal by missing one small detail (lost in a merge conflict resolution, as it turns out).

This PR fixes both of these problems and adds test coverage for the latter.

@mattpolzin mattpolzin requested a review from a team as a code owner June 23, 2023 23:12
@mattpolzin mattpolzin merged commit a2728f5 into beam-community:main Jun 26, 2023
13 checks passed
@mattpolzin mattpolzin deleted the fix-relationships-spec branch June 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mattpolzin