Format required checks for relationships #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures, when relationships are specified, that the root is an object and reach relationships contains a data member with a well-formed resource linkage per: * https://jsonapi.org/format/#crud-creating * https://jsonapi.org/format/#crud-updating-resource-relationships * https://jsonapi.org/format/#document-resource-object-relationships * https://jsonapi.org/format/#document-resource-object-linkage
matt-glover
commented
Jun 28, 2023
| @spec send_error(Plug.Conn.t(), term()) :: term() | ||
| def send_error(conn, %{errors: [%{status: status}]} = error), | ||
| do: send_error(conn, status, error) | ||
|
|
||
| def send_error(conn, %{errors: errors} = error) when is_list(errors) do | ||
| status = Enum.max_by(errors, &Map.get(&1, :status)) |
There was a problem hiding this comment.
Best I can tell this was not called on the latest stable version prior to this PR. I think this is a safe change as long as it works in the new workflows.
mattpolzin
reviewed
Jun 30, 2023
Uses a new `error_attrs` type to represent the raw output of `build_error`. This is the output of some of the newer error functions. Also includes an `error_attrs` suffix on those functions to highlight that they return the raw `build_error` output structure instead of the JSON:API-friendly error structure returned by most of the other ErrorView functions.
|
Best I can tell some sort of build cache error caused linting to fail. Seems to lint fine for me locally. |
mattpolzin
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the JSON:API format verification plug to include checks for the relationships key when creating and updating resources.
This is intended to address: #294
Additionally this PR:
ErrorView.send_error/2because I don't think it extracted the status code previously