Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform relationship keys with shallow field transformation options (#314) #315

Merged

Conversation

protestContest
Copy link
Contributor

Closes #314.

This makes the name of expand_root_keys/2 make less sense, so I'm open to alternative suggestions.

@protestContest protestContest requested a review from a team as a code owner February 22, 2024 20:05
mattpolzin
mattpolzin previously approved these changes Feb 23, 2024
Copy link
Member

@mattpolzin mattpolzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name is still fine. I'm as into bike shedding as the next person. but since I am not sure I think "expand" is the word I would use for this or expand_fields anyway, the "root_keys" bit feels just as reasonable; close enough :)

@mattpolzin
Copy link
Member

@protestContest do you mind making these changes in this PR for a new version to save a little time? I want to release this as 1.7.1.

@protestContest
Copy link
Contributor Author

You mean just bumping the version and adding to the changelog? I can do that.

@mattpolzin mattpolzin force-pushed the transform-relationships-shallow branch from c18e722 to 91aa3cc Compare February 23, 2024 20:16
@mattpolzin
Copy link
Member

GitHub now allows me to rebase this branch on main with a button so I couldn't resist.

@mattpolzin mattpolzin merged commit 00d01cf into beam-community:main Feb 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Relationship keys not transformed with dasherize_shallow config option
2 participants