Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creating a card with cardholder as a cardholder struct throws #519

Closed
pwcsquared opened this issue Jul 8, 2019 · 1 comment · Fixed by jcartwright/stripity_stripe#2
Closed

Creating a card with cardholder as a cardholder struct throws #519

pwcsquared opened this issue Jul 8, 2019 · 1 comment · Fixed by jcartwright/stripity_stripe#2

Comments

@pwcsquared
Copy link
Contributor

The spec for Stripe.Issuing.Card.create/2 specifies an optional cardholder struct as a param:
optional(:cardholder) => Stripe.Issuing.Cardholder.t()
but actually passing in a cardholder struct throws protocol Enumerable not implemented for %Stripe.Issuing.Cardholder{}. Passing just cardholder.id as cardholder in the params works, though.

Seems that it's getting stuck here:
lib/uri_query.ex:37: UriQuery.params/2
lib/stripe/uri.ex:35: Stripe.URI.encode_query/1
@jcartwright
Copy link
Contributor

@pwcsquared I think I know how to fix this.

jcartwright pushed a commit to jcartwright/stripity_stripe that referenced this issue Jul 30, 2019
Cast cardholder to id
2b3fe7a 
- fixes beam-community#519: Creating a card with cardholder as a cardholder struct throws
@jcartwright jcartwright mentioned this issue Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cast cardholder to id (#526) beam-community/stripity-stripe
2 participants
@jcartwright @pwcsquared