Add Stripe.Card #118
Merged
Add Stripe.Card #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsmith
reviewed
Nov 11, 2016
| :address_zip, :address_zip_check, :brand, :country, | ||
| :customer, :cvc_check, :dynamic_last4, :exp_month, :exp_year, | ||
| :fingerprint, :funding, :last4, :metadata, :name, :recipient, | ||
| :tokenization_method, :number |
There was a problem hiding this comment.
Should fix alpha ordering here.
| @valid_create_keys [ | ||
| :exp_month, :exp_year, :number, :address_city, :address_country, | ||
| :address_line1, :address_line2, :address_state, :address_zip, | ||
| :cvc, :metadata, :name |
There was a problem hiding this comment.
Should fix alpha ordering here.
| @valid_update_keys [ | ||
| :exp_month, :exp_year, :address_city, :address_country, | ||
| :address_line1, :address_line2, :address_state, :address_zip, | ||
| :metadata, :name |
There was a problem hiding this comment.
Should fix alpha ordering here.
| ] | ||
|
|
||
| @customer_endpoint "customers" | ||
| @recipient_endpoint "recipients" |
There was a problem hiding this comment.
Looks like we should remove these?
|
@joshsmith - all comments should be addressed now |
green-arrow
commented
Nov 11, 2016
| :id, :address_city, :address_country, :address_line1, | ||
| :address_line1_check, :address_line2, :address_state, | ||
| :address_zip, :address_zip_check, :brand, :country, | ||
| :customer, :cvc_check, :dynamic_last4, :exp_month, :exp_year, |
There was a problem hiding this comment.
Can we remove the cvc_check since we don't have cvc anymore?
There was a problem hiding this comment.
No, that's returned from the API, but not created.
| :address_line1_check, :address_line2, :address_state, | ||
| :address_zip, :address_zip_check, :brand, :country, | ||
| :customer, :cvc_check, :dynamic_last4, :exp_month, :exp_year, | ||
| :fingerprint, :funding, :last4, :metadata, :name, :number, |
There was a problem hiding this comment.
We should get rid of number
|
@green-arrow updated to fix comments. |
joshsmith
force-pushed
the
109-add-stripe-card
branch
from
ca693b1
to
3b796b2
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #109.
Adds create, retrieve, update, and delete capability for a Stripe.Card.
Also adds in a convenience method for translating a stripe API response to a given struct. Additional manipulation may need to be performed to get dates in the proper format as well as for nested structs, but this will take care of most of the heavy lifting.