Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add @valid_update_keys to account #171

Merged
merged 1 commit into from Dec 20, 2016
Merged

Add @valid_update_keys to account #171

merged 1 commit into from Dec 20, 2016

Conversation

begedin
Copy link
Contributor

@begedin begedin commented Dec 20, 2016

During #166 , I forgot to add an @valid_update_keys attribute. We really need to start doing some test coverage :(

@begedin begedin changed the base branch from master to 2.0 December 20, 2016 17:29
@joshsmith
Copy link
Contributor

@begedin yeah, I think @DavidAntaramian has time this week to start on that.

@joshsmith
Copy link
Contributor

👍 LGTM.

@begedin begedin merged commit b9c2262 into 2.0 Dec 20, 2016
@begedin begedin deleted the add-valid-update-keys branch December 20, 2016 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@begedin @joshsmith