Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes to account #178

Merged
merged 1 commit into from Jan 2, 2017
Merged

Minor fixes to account #178

merged 1 commit into from Jan 2, 2017

Conversation

begedin
Copy link
Contributor

@begedin begedin commented Jan 2, 2017

Fixes #176, #177

Adds tos_acceptance under Account struct keys
Adds special instance of convert_values, which matches a DateTime struct.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 25.463% when pulling 9b2f3ee on minor-fixes-to-account into f1da506 on 2.0.

@@ -100,7 +101,7 @@ defmodule Stripe.Account do
phone_number: [:create, :retrieve, :update],
ssn_last_4: [:create, :update], # US only
ssn_last_4_provided: [:retrieve],
type: [:create, :update, :retrieve], # "individual" or "company"
type: [:create, :update, :retrieve], # "individual" or "company",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra comma

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 25.463% when pulling 39707e0 on minor-fixes-to-account into f1da506 on 2.0.

@begedin
Copy link
Contributor Author

begedin commented Jan 2, 2017

@joshsmith Tests pass here and using this branch in our own project has all the tests passing, so this ought to be good to go. From now on, stripity_stripe works with unix integer timestamps only.

Feel free to mark as awaiting review and merging, if you feel it's tested well enough.

@joshsmith joshsmith merged commit a611f7e into 2.0 Jan 2, 2017
@joshsmith joshsmith deleted the minor-fixes-to-account branch January 2, 2017 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants