Add Stripe.Token.create

[sylver]

This function is meant to be only used in Unit Tests to simulate a token provided by the client.

[coveralls]

Coverage decreased (-0.1%) to 26.147% when pulling 5e85cb8 on sylv3r:feature/add-stripe-token-create into adb8603 on code-corps:2.0.

[joshsmith]

We can perhaps handle this with some upcoming testing work we're planning on doing. I'm not sure it's a good idea to implement a public API for doing something that only helps with testing.

[sylver]

I was also wondering if this is something to actually do or not.

Here's my thoughts :
Stripe implements it in its API, all other languages libraries implement it too.
I think the goal of a library like this one is to reflect nearly perfectly the REST API it is based on, it doesn't have to make choice on what is best or not to the end user.
Since Stripe implements it, someone could want to use it, this is the responsibility of a library to be exhaustive and not to take position on whether implements this or that.

[sylver]

@joshsmith @begedin, any thoughts about this one ?

[joshsmith]

I think if we do it, it should be done as a create and we note it in the documentation.

[coveralls]

Coverage decreased (-0.1%) to 26.027% when pulling 4f4b48f on sylv3r:feature/add-stripe-token-create into fab5b57 on code-corps:2.0.

[sylver]

Right @joshsmith, I just updated the PR accordingly.

[joshsmith]

You need to pass in your publishable key for this to work?

[sylver]

That was a false assumption of mine, since it has to be with the publishable key on the client side, I supposed we needed it too on direct API requests for creating a token (it works with both, though). In the API Docs they are giving an example with a secret key as a parameter.
https://stripe.com/docs/api#create_card_token

I will remove the requirement for the publishable key as an argument in the doc section.

[sylver]

@joshsmith just updated the doc section.

[coveralls]

Coverage decreased (-0.1%) to 26.027% when pulling 950ddda on sylv3r:feature/add-stripe-token-create into fab5b57 on code-corps:2.0.

[asummers]

This is fine enough for me 👍

[sylver]

Thanks !