Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Coupon support #236

Merged
merged 1 commit into from Jun 5, 2017
Merged

Add Coupon support #236

merged 1 commit into from Jun 5, 2017

Conversation

Awea
Copy link
Contributor

@Awea Awea commented Jun 3, 2017

No description provided.

@Awea Awea changed the title ✨ Add Coupon support Add Coupon support Jun 3, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 19.635% when pulling 38a1b8a on Awea:2.0 into 328dbd0 on code-corps:2.0.

@begedin
Copy link
Contributor

begedin commented Jun 5, 2017

@Awea Looks good. Most of our testing is lacking, so we won't bug you with that, but there is one tiny test which can be written.

In test/stripe/util_test.ex, we can assert that the object_name_to_module/1 function is working with coupons:

assert object_name_to_module("coupon") == Stripe.Coupon

The order is alphabetized, so putting it between card and customer should be enough. I'd do it myself, but you're using your own fork. Once that's done, we can go ahead and merge this. Just don't forget to then squat your commits into a single commit. You can even amend the change into the existing commit.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 19.635% when pulling ac22758 on Awea:2.0 into 328dbd0 on code-corps:2.0.

@Awea
Copy link
Contributor Author

Awea commented Jun 5, 2017

Most of our testing is lacking, so we won't bug you with that, but there is one tiny test which can be written.

@begedin Yeah I saw it when I checkout 2.0 and run the tests ^^ Anyway it's a good library, it's pretty simple to add a Stripe resource! I've added the assertion.

…I'd do it myself, but you're using your own fork.

There is another way to do it? I'm not used to pull-request.

@begedin
Copy link
Contributor

begedin commented Jun 5, 2017

There is another way to do it? I'm not used to pull-request.

If you're a project contributor, then you can make a branch on this repo and make a PR out of that. You did it correctly, the only way you could.

@begedin begedin merged commit bde2772 into beam-community:2.0 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants