Format misc files #318
Merged
Format misc files #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asummers
reviewed
Nov 22, 2017
test/stripe/error_test.exs
Outdated
| @@ -10,7 +10,10 @@ defmodule Stripe.ErrorTest do | |||
| error = Error.from_stripe_error(400, nil, "id") | |||
| assert error.code == :bad_request | |||
| assert error.extra.http_status == 400 | |||
| assert error.message == "The request was unacceptable, often due to missing a required parameter." | |||
|
|
|||
| assert error.message == | |||
There was a problem hiding this comment.
Maybe name this something like expected_message, so you don't break in middle.
asummers
reviewed
Nov 22, 2017
test/support/stripe_mock.ex
Outdated
| def handle_info({:DOWN, os_pid, :process, _ex_pid, _reason}, %{os_pid: os_pid, opts: opts, restarting: {true, from}} = state) do | ||
| def handle_info( | ||
| {:DOWN, os_pid, :process, _ex_pid, _reason}, | ||
| %{os_pid: os_pid, opts: opts, restarting: {true, from}} = state |
There was a problem hiding this comment.
They recommend doing this match as the first line of the function since it's immaterial to the function being invoked.
asummers
reviewed
Nov 22, 2017
test/support/stripe_mock.ex
Outdated
| executable = opts[:stripe_mock_path] || System.find_executable("stripe-mock") | ||
|
|
||
| unless executable, | ||
| do: |
There was a problem hiding this comment.
I would turn this into a proper block.
|
Changes Unknown when pulling 9da36b2 on format-misc into ** on 2.0-beta**. |
1 similar comment
|
Changes Unknown when pulling 9da36b2 on format-misc into ** on 2.0-beta**. |
joshsmith
force-pushed
the
format-misc
branch
from
9da36b2
to
46de987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.