Corrected types and params for coupon.ex in subscriptions as a small … #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…POC fo the work. If this is acceptable, will do the same patterns for the remaining files
1 similar comment
begedin
requested changes
Jan 3, 2018
lib/stripe/subscriptions/coupon.ex
Outdated
| percent_off: pos_integer | nil, | ||
| redeem_by: Stripe.timestamp() | nil, | ||
| times_redeemed: non_neg_integer, | ||
| valid: boolean |
There was a problem hiding this comment.
In elixir 1.6 all functions/types will be formatted with parentheses, so it will be Stripe.id(), String.t(), etc.
I'm not sure if that's final, but it's in RC, so going back on it here probably means more work later. Mind reverting to parentheses?
|
@begedin Done. I should have run mix format before I committed and did not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…POC fo the work. If this is acceptable, will do the same patterns for the remaining files
Progress on #266, #263