Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return tuple instead of raising an error when http request fails #343

Merged
merged 1 commit into from Apr 3, 2018
Merged

Return tuple instead of raising an error when http request fails #343

merged 1 commit into from Apr 3, 2018

Conversation

bendaleco
Copy link

No description provided.

@bendaleco bendaleco mentioned this pull request Mar 31, 2018
Closed
@coveralls
Copy link

coveralls commented Mar 31, 2018 •
edited

Coverage Status

Coverage increased (+2.9%) to 82.623% when pulling 50f3b4c on bendaleco:errors_handling into 9a070f8 on code-corps:master.

snewcomer
snewcomer approved these changes Mar 31, 2018
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good fix for those using the master branch! (vs 2.0.0 alpha and beta branches)

begedin
begedin approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@begedin begedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay on the review. This looks fine.

@begedin begedin merged commit af6023f into beam-community:master Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begedin begedin begedin approved these changes

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bendaleco @coveralls @begedin @snewcomer