Bump Stripe API to 2018-08-23 #415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
approved these changes
Sep 7, 2018
| @@ -28,7 +28,7 @@ defmodule Stripe.Coupon do | |||
| max_redemptions: pos_integer | nil, | |||
| metadata: Stripe.Types.metadata(), | |||
| name: String.t() | nil, | |||
| percent_off: pos_integer | nil, | |||
| percent_off: number | nil, | |||
There was a problem hiding this comment.
Would you mind changing tax_percent in invoice as well?
| @@ -7,7 +7,8 @@ defmodule Stripe.CustomerTest do | |||
| end | |||
|
|
|||
| test "is retrievable" do | |||
| assert {:ok, %Stripe.Customer{}} = Stripe.Customer.retrieve("cus_123") | |||
| assert {:ok, %Stripe.Customer{} = cus} = Stripe.Customer.retrieve("cus_123") | |||
There was a problem hiding this comment.
cus - is this variable unused?
There was a problem hiding this comment.
Oops, that's a hold-over from some manual verification. I will remove.
| is deprecated. Use `Subscription.update/2` with | ||
| `cancel_at_period_end: true` instead. | ||
| """ | ||
| @deprecated "Use Stripe.Subscription.update/2 with `cancel_at_period_end: true`" |
| @deprecated "Use Stripe.Subscription.update/2 with `cancel_at_period_end: true`" | ||
| @spec delete(Stripe.id() | t, %{at_period_end: true}) :: {:ok, t} | {:error, Stripe.Error.t()} | ||
| def delete(id, %{at_period_end: true}), | ||
| do: update(id, %{cancel_at_period_end: true}, []) |
There was a problem hiding this comment.
Could leave off the [] if you wanted. Up to you though.
mcrumm
force-pushed
the
stripe-api-2018-08-23
branch
from
852176d
to
2f1e40f
Compare
|
@snewcomer Okay, ready for another look! |
snewcomer
requested changes
Sep 7, 2018
| @@ -137,7 +136,6 @@ defmodule Stripe.Subscription do | |||
| optional(:metadata) => Stripe.Types.metadata(), | |||
| optional(:prorate) => boolean, | |||
| optional(:proration_date) => Stripe.timestamp(), | |||
| optional(:source) => Stripe.id() | Stripe.Source.t(), | |||
| optional(:tax_percent) => float, | |||
| optional(:trial_end) => Stripe.timestamp(), | |||
| optional(:trial_from_plan) => boolean | |||
There was a problem hiding this comment.
@mcrumm A couple more spots to remove :source, specifically in the cast_to_id helper function.
There was a problem hiding this comment.
Drat, thanks for catching that!
There was a problem hiding this comment.
@snewcomer Should be good to go now
mcrumm
force-pushed
the
stripe-api-2018-08-23
branch
from
2f1e40f
to
bc214c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripe.APIversion to2018-08-23tax_infoonStripe.Customer(already exists! 馃帀)percent_offinStripe.Couponbusiness_vat_idfromStripe.CustomersourcefromStripe.Subscription.create/2sourcefromStripe.Subscription.update/2Stripe.Subscription.delete/2withat_period_end: trueStripe.Subscription.delete/3@snewcomer Pretty sure all of the above are 馃憤, but if you wouldn't mind checking them off when you feel the same way, that would be great!