New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Dialyxir in CI #424
Get Dialyxir in CI #424
Conversation
I'm chipping away at these dialyzer errors bit by bit and I wanted to confirm something. There were a fews typespecs that were specifying a return value of |
body is getting serialized before passing into this fuction now, so it no longer accepts a map
The id is [required according to the API docs](https://stripe.com/docs/api/application_fees/retrieve#retrieve_application_fee-id) So it seems reasonable that it would be required in the library as well
There are a few issues with the test code/test dependencies, but we don't care about type-checking that
If anyone gets a few minutes to review this, the code is now running dialyzer quickly and cleanly on CI. The changes were almost entirely just changing typespecs on things. There were several types (ie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow what an awesome PR! So many small errors caught (most likely by my own doing). Wish we had this earlier. 🙇
This is a first pass at #183
The goal for this PR is to get a simple dialyzer setup that works pretty quickly in CI and helps to catch any typespec errors.