Add missing invoice attributes #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maartenvanvliet Would you mind updating this branch with master? Just merged in some dialyxir additions! |
snewcomer
reviewed
Nov 14, 2018
lib/stripe/subscriptions/invoice.ex
Outdated
| @@ -51,6 +53,7 @@ defmodule Stripe.Invoice do | |||
| receipt_number: String.t() | nil, | |||
| starting_balance: integer, | |||
| statement_descriptor: String.t() | nil, | |||
| status: String.t(), | |||
snewcomer
reviewed
Nov 14, 2018
| @@ -33,10 +33,12 @@ defmodule Stripe.Invoice do | |||
| currency: String.t(), | |||
| customer: Stripe.id() | Stripe.Customer.t(), | |||
| date: Stripe.timestamp(), | |||
| default_source: String.t() | nil, | |||
There was a problem hiding this comment.
Looks like one can pass this field to update and create as well
maartenvanvliet
force-pushed
the
issues/missing_invoice_attrs
branch
from
a9f6ea0
to
7db6273
Compare
|
@maartenvanvliet Feel free to merge in master when you have a chance. Just to make sure we don't miss any dialyzer errors 👍. Then is is g2g! Nice work! |
|
I rebased on master 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing invoice attributes to the Invoice struct.
See: https://stripe.com/docs/api/invoices/object and https://raw.githubusercontent.com/stripe/openapi/master/openapi/spec3.yaml
Another attribute,
payment_intentis also sent by Stripe, this is not documented so I've not added it.