Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use singular time units in System.system_time/1 #450

Merged

Conversation

maartenvanvliet
Copy link
Member

Plural is deprecated and gives an error:
warning: deprecated time unit: :seconds. A time unit should be :second, :millisecond, :microsecond, :nanosecond, or a positive integer

Plural is deprecated and gives an error:
warning: deprecated time unit: :seconds. A time unit should be :second, :millisecond, :microsecond, :nanosecond, or a positive integer
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 553941b on maartenvanvliet:fix_elixir_1.8_deprecations into df4b54b on code-corps:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 83.071% when pulling 553941b on maartenvanvliet:fix_elixir_1.8_deprecations into df4b54b on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snewcomer snewcomer merged commit 9bac54d into beam-community:master Jan 17, 2019
@maartenvanvliet maartenvanvliet deleted the fix_elixir_1.8_deprecations branch January 17, 2019 20:11
@hazen
Copy link

hazen commented Feb 28, 2019

@snewcomer Any idea when a release with this fix might be forthcoming? Would love to clean up our CI warnings. Thanks!

@snewcomer
Copy link
Collaborator

Seeking publish rights. Still in limbo. Only thing I can think of doing is pointing at a commit sha if possible for your setup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants