Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CreditNote api calls #492

Merged

Conversation

maartenvanvliet
Copy link
Member

See https://stripe.com/docs/api/credit_notes?lang=ruby
CreditNote were added to Stripe, I've added them in this PR following the open api spec.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.765% when pulling b5cb9e5 on maartenvanvliet:issues/add_credit_notes into 7c54802 on code-corps:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.765% when pulling b5cb9e5 on maartenvanvliet:issues/add_credit_notes into 7c54802 on code-corps:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.765% when pulling b5cb9e5 on maartenvanvliet:issues/add_credit_notes into 7c54802 on code-corps:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.765% when pulling b5cb9e5 on maartenvanvliet:issues/add_credit_notes into 7c54802 on code-corps:master.

@coveralls
Copy link

coveralls commented May 8, 2019

Coverage Status

Coverage increased (+0.2%) to 86.063% when pulling 33c8ac2 on maartenvanvliet:issues/add_credit_notes into b67831f on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One comment and I think if you merge master, the tests will pass.

@type t :: %__MODULE__{
id: Stripe.id(),
object: String.t(),
amount: number,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be integer or is number valid as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, good catch :) Pushed a new version

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💳

@snewcomer snewcomer merged commit 28997ea into beam-community:master May 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants