Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PaymentMethods module, with struct, list/2, attach/2, detach/2 #495

Merged
merged 3 commits into from May 23, 2019
Merged

Add PaymentMethods module, with struct, list/2, attach/2, detach/2 #495

merged 3 commits into from May 23, 2019

Conversation

begedin
Copy link
Contributor

@begedin begedin commented May 10, 2019

  • card_present not listed on module, since there's little documentation on it

@begedin
Add PaymentMethods module, with struct, list/2, attach/2, detach/2
b1ee33c 
- card_present not listed on module, since there's little documentation on it
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.74% when pulling b1ee33c on add-payment-methods-list-attach-detach into 67bf463 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.74% when pulling b1ee33c on add-payment-methods-list-attach-detach into 67bf463 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 85.74% when pulling b1ee33c on add-payment-methods-list-attach-detach into 67bf463 on master.

@coveralls
Copy link

coveralls commented May 10, 2019 •
edited

Coverage Status

Coverage increased (+0.3%) to 85.866% when pulling 3ed1737 on add-payment-methods-list-attach-detach into 67bf463 on master.

snewcomer
snewcomer reviewed May 14, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to also add create, update and retrieve or would you like me to do that in a follow up PR?

lib/stripe/payment_methods/payment_method.ex Outdated
@doc """
Dettach payment_method from customer
"""
@spec dettach(params, Stripe.options()) :: {:ok, t} | {:error, Stripe.Error.t()}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r/dettach/detach

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Do we want to also add create, update and retrieve or would you like me to do that in a follow up PR?

I probably won't be able to until possibly this weekend or next week, so it all depends on how quickly you want this merged.

r/dettach/detach

That's weird. I know it's spelled that way, but I was pretty damn consistent in misspelling it :)

snewcomer
snewcomer approved these changes May 22, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💳

@snewcomer
Copy link
Collaborator

@begedin Feel free to merge when you are ready! If you merge master, tests should pass.

@begedin begedin merged commit b67831f into master May 23, 2019
@begedin begedin deleted the add-payment-methods-list-attach-detach branch May 23, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

@joshsmith joshsmith Awaiting requested review from joshsmith

Assignees
No one assigned
Labels
needs code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@begedin @coveralls @snewcomer