Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sending invoices. #510

Merged
merged 3 commits into from Jun 9, 2019

Conversation

radglob
Copy link

@radglob radglob commented Jun 3, 2019

Stripe.Invoice.send/2 was missing from the lib/stripe/subscriptions/invoice.ex. Added the endpoint and an additional test to the corresponding test file.

@coveralls
Copy link

coveralls commented Jun 3, 2019

Coverage Status

Coverage increased (+0.3%) to 87.442% when pulling 7a9605f on staffing-coop:add-send-invoice into 0d3e134 on code-corps:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 87.22% when pulling b3127d8 on staffing-coop:add-send-invoice into 0d3e134 on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add! 👍

@@ -264,4 +264,15 @@ defmodule Stripe.Invoice do
|> put_method(:post)
|> make_request()
end

@doc """
Send an invoice
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind adding this link to the documentation?

https://stripe.com/docs/api/invoices/send

@radglob
Copy link
Author

radglob commented Jun 9, 2019

Added the link at the end of the docstring for this method. Is that the best way to do that? I don't see any other function-level examples.

@snewcomer snewcomer merged commit fae1e70 into beam-community:master Jun 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants