Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when unknown objects are processed #514

Merged

Conversation

maartenvanvliet
Copy link
Member

When the converter sees an unknown object in dev/test env it should issue a warning.
Also changed the logger level when the converter encounters unknown keys in dev/test so it'll output those fields when running the tests.

Fixes #306

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 87.481% when pulling 741dbfa on maartenvanvliet:issues/warn_unknown_objects into fae1e70 on code-corps:master.

@coveralls
Copy link

coveralls commented Jun 10, 2019

Coverage Status

Coverage increased (+0.04%) to 87.481% when pulling b65ad74 on maartenvanvliet:issues/warn_unknown_objects into fae1e70 on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snewcomer snewcomer merged commit cbfe8b2 into beam-community:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add warning to Converter when we get an unexpected object
3 participants