Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Stripe.Topup #527

Merged
merged 4 commits into from Aug 13, 2019
Merged

Add Stripe.Topup #527

merged 4 commits into from Aug 13, 2019

Conversation

jcartwright
Copy link
Contributor

Add the Stripe.Topup object as defined in the API Docs https://stripe.com/docs/api/topups

@coveralls
Copy link

coveralls commented Jul 31, 2019 •
edited

Coverage Status

Coverage increased (+0.1%) to 88.166% when pulling 34abd47 on jcartwright:add-topup into 952664e on code-corps:master.

@jcartwright
Copy link
Contributor Author

@snewcomer anything else I need to do to get this PR reviewed and merged? Thanks!

snewcomer
snewcomer approved these changes Aug 11, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

100%!! Very nice work and thank you. Once the merge conflicts are fixed, I'll merge!

@jcartwright
Copy link
Contributor Author

@snewcomer I think this is ready to go now.

@snewcomer snewcomer merged commit 1510f7c into beam-community:master Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
2.0 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jcartwright @coveralls @snewcomer