Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow all keys to be converted to atoms #529

Merged
merged 1 commit into from Aug 9, 2019
Merged

Allow all keys to be converted to atoms #529

merged 1 commit into from Aug 9, 2019

Conversation

kerryjj
Copy link
Contributor

@kerryjj kerryjj commented Aug 9, 2019

This is my suggested fix for Issue #516

@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.024% when pulling a2ba003 on blendmedia:convert-all-keys-to-atoms into 521ec7f on code-corps:master.

snewcomer
snewcomer approved these changes Aug 9, 2019
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed and thanks for the thorough issue explanation. Also see no need to strictly ensure the atom is already in our system.

@snewcomer snewcomer merged commit 79d6334 into beam-community:master Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
2.0 enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kerryjj @coveralls @snewcomer