Add payment_method to confirm payment intent #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow confirming a payment intent using a payment method. This appears to be the newest way of confirming a payment, deprecating the source field. I believe it's best to leave both options in for backwards compatibility https://stripe.com/docs/api/payment_intents/confirm#confirm_payment_intent-payment_method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow confirming a payment intent using a payment method. This appears
to be the newest way of confirming a payment, deprecating the source
field.
I believe it's best to leave both options in for backwards compatibility
https://stripe.com/docs/api/payment_intents/confirm#confirm_payment_intent-payment_method
I also added in a cast_to_id call that appeared to be missing in the confirm function.