New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add promotion codes #641
Add promotion codes #641
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great addition! Only a few comments.
when params: | ||
%{ | ||
optional(:metadata) => Stripe.Types.metadata(), | ||
optional(:active) => boolean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://stripe.com/docs/api/promotion_codes/update
Is metadata
possible to pass here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears to be, yes, which is why I added it on line 100. I'm not sure I understand your comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh my. my eyes failed me!
|
Whoops, indeed it is. Not sure how I missed that. Should be a very simple change to add |
I think the |
Also update API spec to include the
/v1/promotion_codes
endpoints, which required updating some unrelated tests