Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow api_version to be set from config #656

Merged
merged 1 commit into from Mar 6, 2021

Conversation

stoyle
Copy link
Contributor

@stoyle stoyle commented Mar 4, 2021

The docs states you should be able to set api_version through config, as far as I can tell this should be valid:

config :stripity_stripe,
  api_version: "2020-08-27",
  api_key: "sk_test_xxx"

However api_version is not read. With this change it is.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 90.256% when pulling d8d2b0e on stoyle:api_version_from_config into b0d1651 on code-corps:master.

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition!

@snewcomer snewcomer merged commit 02f9cdd into beam-community:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants