Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds expiry feature #702

Merged
merged 5 commits into from Dec 16, 2021
Merged

Adds expiry feature #702

merged 5 commits into from Dec 16, 2021

Conversation

jekku
Copy link
Contributor

@jekku jekku commented Dec 1, 2021 •
edited

What's here?

  • This expires a session provided an ID
  • This is an important feature to prevent code overhead on duplicate payments caused by payment sessions

Some other prerequisites included

  • Stripe Mock had to be upgraded to v0.116.0
  • The docker image being pulled is now the official one hosted by Stripe. The old one seems to look unmaintained, with no one in sight to contact anyway.

References

@jekku jekku changed the title Adds expiry feature Adds expiry feature [WIP] Dec 1, 2021
@jekku jekku changed the title Adds expiry feature [WIP] Adds expiry feature Dec 1, 2021
@jekku jekku mentioned this pull request Dec 3, 2021
Merged
snewcomer
snewcomer approved these changes Dec 16, 2021
View reviewed changes
Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

.github/workflows/ci.yml
@@ -23,7 +23,7 @@ jobs:
otp: [24]
services:
stripe-mock:
image: stripemock/stripe-mock:v0.110.0
image: stripe/stripe-mock:v0.116.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@snewcomer snewcomer merged commit a380556 into beam-community:master Dec 16, 2021
@jekku jekku deleted the feature/session-expiry branch December 29, 2021 14:23
@jekku
Copy link
Contributor Author

jekku commented Dec 29, 2021

Thanks mate. If you need anyone to make a release or manage releases, I'm free once every few weekends 😉 🤙🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snewcomer snewcomer snewcomer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jekku @snewcomer