Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to Payment Links as core_resource #719

Conversation

vittoriabitton
Copy link
Contributor

Adds support to PaymentLink as a core_resource.

Stripe docs: https://stripe.com/docs/payments/payment-links/api

@vittoriabitton
Copy link
Contributor Author

Hey, @joshsmith @snewcomer do you folks mind checking this PR out? 😁 It will help us a ton!

@snewcomer
Copy link
Collaborator

@vittoriabitton Great! Looks like we have a failing test on OTP 24/Elixir 1.12.

@vittoriabitton
Copy link
Contributor Author

vittoriabitton commented Apr 18, 2022

Hey, @snewcomer thanks for the reply!

Locally the same test file passes :/ in the CI pipeline it fails in building the request URL and I'm wondering if there is a different configuration for the CI for the assert_stripe_requested/3 for fetching the base URL or something. Maybe you can help us here?

Thanks a lot in advance!

@vittoriabitton
Copy link
Contributor Author

Going through the ci.yml seems everything is fine...I'm not sure if it is some env var on the ConfigTest module.

@vittoriabitton
Copy link
Contributor Author

One thing that I've noticed is that is missing the handle_info callback implementation for StripeMock so when I run a plain mix test it just shuts the application (I guess this can be either fixed or configured on the supervision tree), giving this error.

Screen Shot 2022-04-18 at 20 49 20

So I'm basically running one single test at a time (that does not require the GenServer to be up and running)...so not sure if missed something here 😅. But would be glad to help too if I can have a bit more context.
Screen Shot 2022-04-18 at 20 49 03

@snewcomer
Copy link
Collaborator

With the bump something about TerminalLocation has changed?

Screen Shot 2022-04-21 at 9 37 47 AM

@vittoriabitton
Copy link
Contributor Author

@snewcomer can you run the CI again, please? 😄

Copy link
Collaborator

@snewcomer snewcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@snewcomer snewcomer merged commit 42db03f into beam-community:master May 6, 2022
@mlexs
Copy link

mlexs commented May 11, 2022

Thank you! 😍 Exactly what I need just now.

@vittoriabitton vittoriabitton deleted the vb-add-support-to-payment-links branch July 1, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants